forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 10:22:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

eth/fetcher: drop the duplicated sanitize

Browse source
This commit is contained in:
Gary Rong 2024-08-13 16:22:48 +08:00
parent c1f19734cc
commit 46cbfe405d
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
eth/fetcher/tx_fetcher.go
View file

@ -237,12 +237,6 @@ func NewTxFetcherForTests(
// Notify announces the fetcher of the potential availability of a new batch of // Notify announces the fetcher of the potential availability of a new batch of
// transactions in the network. // transactions in the network.
func (f *TxFetcher) Notify(peer string, types []byte, sizes []uint32, hashes []common.Hash) error { func (f *TxFetcher) Notify(peer string, types []byte, sizes []uint32, hashes []common.Hash) error {
// Sanitize the announcements. Transaction metadata has been available since eth68,
// and all legacy eth protocols have been deprecated. Therefore, metadata is always
// expected in the announcement.
if len(types) != len(sizes) || len(types) != len(hashes) {
return errors.New("invalid transaction announcements")
}
// Keep track of all the announced transactions // Keep track of all the announced transactions
txAnnounceInMeter.Mark(int64(len(hashes))) txAnnounceInMeter.Mark(int64(len(hashes)))
@ -266,6 +260,10 @@ func (f *TxFetcher) Notify(peer string, types []byte, sizes []uint32, hashes []c
underpriced++ underpriced++
default: default:
unknownHashes = append(unknownHashes, hash) unknownHashes = append(unknownHashes, hash)
// Transaction metadata has been available since eth68, and all
// legacy eth protocols (prior to eth68) have been deprecated.
// Therefore, metadata is always expected in the announcement.
unknownMetas = append(unknownMetas, &txMetadata{kind: types[i], size: sizes[i]}) unknownMetas = append(unknownMetas, &txMetadata{kind: types[i], size: sizes[i]})
} }
} }