review feedback

This commit is contained in:
Guillaume Ballet 2019-11-26 11:33:38 +01:00
parent afaa9e1006
commit 482db9c596

View file

@ -163,7 +163,8 @@ func (w *ledgerDriver) SignTx(path accounts.DerivationPath, tx *types.Transactio
} }
// Ensure the wallet is capable of signing the given transaction // Ensure the wallet is capable of signing the given transaction
if chainID != nil && w.version[0] <= 1 && w.version[2] <= 2 { if chainID != nil && w.version[0] <= 1 && w.version[2] <= 2 {
return common.Address{}, nil, fmt.Errorf("ledger v%d.%d.%d doesn't support signing this transaction, please update to v1.0.3 at least", w.version[0], w.version[1], w.version[2]) //lint:ignore ST1005 brand name displayed on the console
return common.Address{}, nil, fmt.Errorf("Ledger v%d.%d.%d doesn't support signing this transaction, please update to v1.0.3 at least", w.version[0], w.version[1], w.version[2])
} }
// All infos gathered and metadata checks out, request signing // All infos gathered and metadata checks out, request signing
return w.ledgerSign(path, tx, chainID) return w.ledgerSign(path, tx, chainID)