From 7e5c3cacbcef138315038728dffeb5d664d9006f Mon Sep 17 00:00:00 2001 From: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Date: Sat, 3 Dec 2022 18:50:11 -0800 Subject: [PATCH 1/4] use Box instead of flex Stack for nav items allows vertical margins of children to properly collapse into one another --- src/components/UI/docs/DocumentNav.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/UI/docs/DocumentNav.tsx b/src/components/UI/docs/DocumentNav.tsx index 25663a720b..4526af7725 100644 --- a/src/components/UI/docs/DocumentNav.tsx +++ b/src/components/UI/docs/DocumentNav.tsx @@ -1,5 +1,5 @@ import { FC } from 'react'; -import { Divider, Link, Stack, Text } from '@chakra-ui/react'; +import { Box, Divider, Link, Text } from '@chakra-ui/react'; import NextLink from 'next/link'; import { parseHeadingId } from '../../../utils/parseHeadingId'; @@ -20,7 +20,7 @@ export const DocumentNav: FC = ({ content }) => { const activeHash = useActiveHash(parsedHeadings.map(heading => heading!.headingId)); return ( - + on this page @@ -39,6 +39,6 @@ export const DocumentNav: FC = ({ content }) => { ); })} - + ); }; From e564ae46aa5e81a670e81992fac26bcc2364aba6 Mon Sep 17 00:00:00 2001 From: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Date: Sat, 3 Dec 2022 18:50:23 -0800 Subject: [PATCH 2/4] adjust docs nav gap to 14px per design --- src/components/UI/docs/DocumentNav.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/UI/docs/DocumentNav.tsx b/src/components/UI/docs/DocumentNav.tsx index 4526af7725..21c6f89a08 100644 --- a/src/components/UI/docs/DocumentNav.tsx +++ b/src/components/UI/docs/DocumentNav.tsx @@ -32,6 +32,7 @@ export const DocumentNav: FC = ({ content }) => { {heading?.title} From d93e4373e2b32c5e7772bb89e4c2d9d3717f5a61 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 6 Dec 2022 10:53:11 -0700 Subject: [PATCH 3/4] Update src/components/UI/docs/DocumentNav.tsx Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com> --- src/components/UI/docs/DocumentNav.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/UI/docs/DocumentNav.tsx b/src/components/UI/docs/DocumentNav.tsx index 21c6f89a08..07adf63ad3 100644 --- a/src/components/UI/docs/DocumentNav.tsx +++ b/src/components/UI/docs/DocumentNav.tsx @@ -32,7 +32,7 @@ export const DocumentNav: FC = ({ content }) => { {heading?.title} From 7e9e22a6712aff5ad02809f41e4488a0b41552e4 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 6 Dec 2022 10:54:50 -0700 Subject: [PATCH 4/4] remove margin styles for document-nav-link in textStyles.ts --- src/theme/foundations/textStyles.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/theme/foundations/textStyles.ts b/src/theme/foundations/textStyles.ts index df2c9e9d70..1badd62db0 100644 --- a/src/theme/foundations/textStyles.ts +++ b/src/theme/foundations/textStyles.ts @@ -191,7 +191,6 @@ export const textStyles = { fontSize: '13px', lineHeight: 5, letterSpacing: '1%', - mb: 4 }, 'note-text': { fontFamily: 'body',