From 4bc885e809d091fc12784072a00ae1d140f9b62b Mon Sep 17 00:00:00 2001 From: healthykim Date: Fri, 22 May 2026 14:55:08 +0200 Subject: [PATCH] remove outdated todos --- core/txpool/blobpool/blobpool.go | 2 +- core/txpool/blobpool/buffer.go | 1 - eth/fetcher/blob_fetcher.go | 9 ++------- eth/fetcher/blob_fetcher_test.go | 4 ---- 4 files changed, 3 insertions(+), 13 deletions(-) diff --git a/core/txpool/blobpool/blobpool.go b/core/txpool/blobpool/blobpool.go index 44508c2159..a5cc2f8d87 100644 --- a/core/txpool/blobpool/blobpool.go +++ b/core/txpool/blobpool/blobpool.go @@ -1499,7 +1499,7 @@ func (p *BlobPool) ValidateTxBasics(tx *types.Transaction) error { Accept: 1 << types.BlobTxType, MaxSize: txMaxSize, MinTip: p.gasTip.Load().ToBig(), - MaxBlobCount: maxBlobsPerTx, //todo this field is currently not being used + MaxBlobCount: maxBlobsPerTx, } return txpool.ValidateTransaction(tx, p.head.Load(), p.signer, opts) } diff --git a/core/txpool/blobpool/buffer.go b/core/txpool/blobpool/buffer.go index 519190e39e..24437f4029 100644 --- a/core/txpool/blobpool/buffer.go +++ b/core/txpool/blobpool/buffer.go @@ -32,7 +32,6 @@ import ( "github.com/ethereum/go-ethereum/metrics" ) -// todo: per-peer size limit var ( blobBufferTxFirstCounter = metrics.NewRegisteredCounter("blobpool/buffer/txfirst", nil) blobBufferCellsFirstCounter = metrics.NewRegisteredCounter("blobpool/buffer/cellsfirst", nil) diff --git a/eth/fetcher/blob_fetcher.go b/eth/fetcher/blob_fetcher.go index 1ba0c1c232..a65a0e4171 100644 --- a/eth/fetcher/blob_fetcher.go +++ b/eth/fetcher/blob_fetcher.go @@ -28,8 +28,6 @@ import ( "github.com/ethereum/go-ethereum/crypto/kzg4844" ) -// todo remove partial / full - type random interface { Intn(n int) int } @@ -39,8 +37,6 @@ type random interface { // For availability checks, it fetches cells from each blob in the transaction // according to the custody cell indices provided by the consensus client // connected to this execution client. - -// todo var blobFetchTimeout = 5 * time.Second var blobAvailabilityTimeout = 2 * time.Second @@ -138,9 +134,8 @@ type BlobFetcher struct { // Buffer 2 // Stage 3: Transactions whose payloads/cells are currently being fetched (full fetch + partial fetch) - fetches map[common.Hash]*fetchStatus // Hash -> Bitmap, in-flight transaction cells - requests map[string][]*cellRequest // In-flight transaction retrievals - // todo simplify + fetches map[common.Hash]*fetchStatus // Hash -> Bitmap, in-flight transaction cells + requests map[string][]*cellRequest // In-flight transaction retrievals alternates map[common.Hash]map[string]*types.CustodyBitmap // In-flight transaction alternate origins (in case the peer is dropped) fn BlobFetcherFunctions // callbacks diff --git a/eth/fetcher/blob_fetcher_test.go b/eth/fetcher/blob_fetcher_test.go index 84732e0d92..02b9164ce4 100644 --- a/eth/fetcher/blob_fetcher_test.go +++ b/eth/fetcher/blob_fetcher_test.go @@ -330,9 +330,6 @@ func TestBlobFetcherPartialFetch(t *testing.T) { }) } -// todo wait timeout -// todo drop - // TestBlobFetcherFullDelivery tests cell delivery and fetch completion logic (full fetch) func TestBlobFetcherFullDelivery(t *testing.T) { testBlobFetcher(t, blobFetcherTest{ @@ -809,7 +806,6 @@ func testBlobFetcher(t *testing.T, tt blobFetcherTest) { } case isBlobScheduled: - // todo fetches // Check tracking (announces) - bidirectional verification for peer, announces := range step.announces { peerAnnounces := fetcher.announces[peer]