From 4c7d37399100212d4111a1b1291f9eac217336f1 Mon Sep 17 00:00:00 2001 From: Martin Holst Swende Date: Wed, 14 Aug 2019 09:17:08 +0200 Subject: [PATCH] tests: disable Istanbul tx tests (until updated) --- tests/transaction_test_util.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/transaction_test_util.go b/tests/transaction_test_util.go index cd0079823a..85bf1fb0bd 100644 --- a/tests/transaction_test_util.go +++ b/tests/transaction_test_util.go @@ -80,13 +80,14 @@ func (tt *TransactionTest) Run(config *params.ChainConfig) error { {"EIP158", types.NewEIP155Signer(config.ChainID), tt.EIP158, true, false}, {"Byzantium", types.NewEIP155Signer(config.ChainID), tt.Byzantium, true, false}, {"Constantinople", types.NewEIP155Signer(config.ChainID), tt.Constantinople, true, false}, - {"Istanbul", types.NewEIP155Signer(config.ChainID), tt.Istanbul, true, true}, + //TODO! @holiman or @rjl493456442 : enable this after tests have been updated for Istanbul + //{"Istanbul", types.NewEIP155Signer(config.ChainID), tt.Istanbul, true, true}, } { sender, txhash, err := validateTx(tt.RLP, testcase.signer, testcase.isHomestead, testcase.isIstanbul) if testcase.fork.Sender == (common.UnprefixedAddress{}) { if err == nil { - return fmt.Errorf("Expected error, got none (address %v)", sender.String()) + return fmt.Errorf("Expected error, got none (address %v)[%v]", sender.String(), testcase.name) } continue }