From 4cc847985c07550d934a7327295d7c7c42825f56 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A9ter=20Szil=C3=A1gyi?= <peterke@gmail.com>
Date: Fri, 22 Sep 2023 10:15:41 +0300
Subject: [PATCH] core/state/snapshot: be very noisy if the generator hits a
 trie error

---
 core/state/snapshot/generate.go | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/core/state/snapshot/generate.go b/core/state/snapshot/generate.go
index 40264b092c..f54debebed 100644
--- a/core/state/snapshot/generate.go
+++ b/core/state/snapshot/generate.go
@@ -446,6 +446,10 @@ func (dl *diskLayer) generateRange(ctx *generatorContext, trieId *trie.ID, prefi
 		internal += time.Since(istart)
 	}
 	if iter.Err != nil {
+		// Trie errors should never happen. Still, in case of a bug, expose the
+		// error here, as the outer code will presume errors are interrupts, not
+		// some deeper issues.
+		log.Error("State snapshotter failed to iterate trie", "err", err)
 		return false, nil, iter.Err
 	}
 	// Delete all stale snapshot states remaining