From 4f7159b11946feab6be548f0d834b66bed5ebea5 Mon Sep 17 00:00:00 2001 From: Daniel Liu <139250065@qq.com> Date: Tue, 10 Feb 2026 19:19:55 +0800 Subject: [PATCH] fix(cmd): fix disabling discovery through config file #33279 (#2003) --- cmd/utils/flags.go | 10 +++++++--- node/defaults.go | 7 ++++--- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go index 7e4d2d78ce..9f5241a354 100644 --- a/cmd/utils/flags.go +++ b/cmd/utils/flags.go @@ -681,9 +681,11 @@ var ( Category: flags.NetworkingCategory, } DiscoveryV5Flag = &cli.BoolFlag{ - Name: "v5disc", - Usage: "Enables the experimental RLPx V5 (Topic Discovery) mechanism", + Name: "discovery-v5", + Aliases: []string{"discv5"}, + Usage: "Enables the V5 discovery mechanism", Category: flags.NetworkingCategory, + Value: node.DefaultConfig.P2P.DiscoveryV5, } NetrestrictFlag = &cli.StringFlag{ Name: "netrestrict", @@ -1296,7 +1298,9 @@ func SetP2PConfig(ctx *cli.Context, cfg *p2p.Config) { } flags.CheckExclusive(ctx, DiscoveryV5Flag, NoDiscoverFlag) - cfg.DiscoveryV5 = ctx.Bool(DiscoveryV5Flag.Name) + if ctx.IsSet(DiscoveryV5Flag.Name) { + cfg.DiscoveryV5 = ctx.Bool(DiscoveryV5Flag.Name) + } if netrestrict := ctx.String(NetrestrictFlag.Name); netrestrict != "" { list, err := netutil.ParseNetlist(netrestrict) diff --git a/node/defaults.go b/node/defaults.go index 32dc01fbf0..5c88d3406c 100644 --- a/node/defaults.go +++ b/node/defaults.go @@ -67,9 +67,10 @@ var DefaultConfig = Config{ BatchRequestLimit: 1000, BatchResponseMaxSize: 25 * 1000 * 1000, P2P: p2p.Config{ - ListenAddr: ":30303", - MaxPeers: 50, - NAT: nat.Any(), + ListenAddr: ":30303", + MaxPeers: 50, + NAT: nat.Any(), + DiscoveryV5: true, }, }