forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-18 19:00:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

add few comments in code

Browse source
This commit is contained in:
Liam Lai 2021-12-21 08:47:23 +03:00
parent db58081b8d
commit 5061dd9841
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
consensus/XDPoS/engines/engine_v1/engine.go
View file

@ -483,6 +483,7 @@ func (x *XDPoS_v1) snapshot(chain consensus.ChainReader, number uint64, hash com
} }
parents = parents[:len(parents)-1] parents = parents[:len(parents)-1]
} else if selfHeader != nil && selfHeader.Hash() == hash { } else if selfHeader != nil && selfHeader.Hash() == hash {
// it prevents db doesn't have current block info, can be removed by refactor blockchain.go reorg function call.
header = selfHeader header = selfHeader
} else { } else {
// No explicit parents (or no more left), reach out to the database // No explicit parents (or no more left), reach out to the database

3
core/blockchain.go
View file

@ -1345,6 +1345,9 @@ func (bc *BlockChain) WriteBlockWithState(block *types.Block, receipts []*types.
reorg = block.NumberU64() > currentBlock.NumberU64() reorg = block.NumberU64() > currentBlock.NumberU64()
} }
// This is the ETH fix. We shall ultimately have this workflow,
// but due to below code has diverged significantly between ETH and XDC, and current issue we have,
// it's best to have it in a different PR with more investigations.
// if reorg { // if reorg {
// // Write the positional metadata for transaction and receipt lookups // // Write the positional metadata for transaction and receipt lookups
// if err := WriteTxLookupEntries(batch, block); err != nil { // if err := WriteTxLookupEntries(batch, block); err != nil {