From 50f71a5024ed1ab1b3bcb5667f39bc02cadbe0ce Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A9ter=20Szil=C3=A1gyi?= <peterke@gmail.com>
Date: Tue, 4 Jul 2017 18:14:14 +0300
Subject: [PATCH] core/types: deserialize receipt RLP based on list size

---
 core/types/receipt.go | 37 ++++++++++++++++++++++++++-----------
 1 file changed, 26 insertions(+), 11 deletions(-)

diff --git a/core/types/receipt.go b/core/types/receipt.go
index a797da2e63..c9906b0154 100644
--- a/core/types/receipt.go
+++ b/core/types/receipt.go
@@ -87,27 +87,42 @@ func (r *Receipt) DecodeRLP(s *rlp.Stream) error {
 	if err != nil {
 		return err
 	}
-	// Attempt to deserialize into a Metropolis format
-	var metro metropolisReceiptRLP
-	if err = rlp.DecodeBytes(raw, &metro); err == nil { // Keep the error in the outer scope!
+	list, _, err := rlp.SplitList(raw)
+	if err != nil {
+		return err
+	}
+	items, err := rlp.CountValues(list)
+	if err != nil {
+		return err
+	}
+	// Deserialize based on the number of content items
+	switch items {
+	case 3:
+		// Metropolis receipts have 3 components
+		var metro metropolisReceiptRLP
+		if err := rlp.DecodeBytes(raw, &metro); err != nil {
+			return err
+		}
 		r.CumulativeGasUsed = metro.CumulativeGasUsed
 		r.Bloom = metro.Bloom
 		r.Logs = metro.Logs
-
 		return nil
-	}
-	// Metropolis deserialization failed, attempt homestead
-	var home homesteadReceiptRLP
-	if err = rlp.DecodeBytes(raw, &home); err == nil { // Keep the error in the outer scope!
+
+	case 4:
+		// Homestead receipts have 4 components
+		var home homesteadReceiptRLP
+		if err := rlp.DecodeBytes(raw, &home); err != nil {
+			return err
+		}
 		r.PostState = home.PostState[:]
 		r.CumulativeGasUsed = home.CumulativeGasUsed
 		r.Bloom = home.Bloom
 		r.Logs = home.Logs
-
 		return nil
+
+	default:
+		return fmt.Errorf("invalid receipt components: %v", items)
 	}
-	// All decoders failed, return the last error
-	return err
 }
 
 // String implements the Stringer interface.