forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-25 06:06:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

eth: return null for not-found in BlockByNumberOrHash

Browse source
This commit is contained in:
Felix Lange 2025-06-02 15:52:09 +02:00
parent 99c0ed1154
commit 51a802c66e
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
eth/api_backend.go
View file

@ -196,7 +196,9 @@ func (b *EthAPIBackend) BlockByNumberOrHash(ctx context.Context, blockNrOrHash r
if hash, ok := blockNrOrHash.Hash(); ok { if hash, ok := blockNrOrHash.Hash(); ok {
header := b.eth.blockchain.GetHeaderByHash(hash) header := b.eth.blockchain.GetHeaderByHash(hash)
if header == nil { if header == nil {
return nil, errors.New("header for hash not found") // Return 'null' and no error if block is not found.
// This behavior is required by RPC spec.
return nil, nil
} }
if blockNrOrHash.RequireCanonical && b.eth.blockchain.GetCanonicalHash(header.Number.Uint64()) != hash { if blockNrOrHash.RequireCanonical && b.eth.blockchain.GetCanonicalHash(header.Number.Uint64()) != hash {
return nil, errors.New("hash is not currently canonical") return nil, errors.New("hash is not currently canonical")