swarm/network: Changed LightNode handhsake test to table driven

This commit is contained in:
Attila Gazso 2018-07-31 12:15:52 +02:00
parent 975e96ceb1
commit 5270b80752

View file

@ -255,44 +255,34 @@ func TestBzzHandshakeSuccess(t *testing.T) {
} }
} }
func TestBzzHandshakeLightNodeOff(t *testing.T) { var lightNodeTests = []struct {
randomAddr := RandomAddr() name string
pt := newBzzHandshakeTester(t, 1, randomAddr, false) lightNode bool
id := pt.IDs[0] }{
addr := NewAddrFromNodeID(id) {"on", true},
peerLightNode := false {"off", false},
err := pt.testHandshake(
correctBzzHandshake(randomAddr, false),
&HandshakeMsg{Version: TestProtocolVersion, NetworkID: TestProtocolNetworkID, Addr: addr, LightNode: peerLightNode},
)
if err != nil {
t.Fatal(err)
}
if pt.bzz.handshakes[id].LightNode != peerLightNode {
t.Fatalf("peer LightNode flag is %v, should be %v", pt.bzz.handshakes[id].LightNode, peerLightNode)
}
} }
func TestBzzHandshakeLightNodeOn(t *testing.T) { func TestBzzHandshakeLightNode(t *testing.T) {
randomAddr := RandomAddr() for _, test := range lightNodeTests {
pt := newBzzHandshakeTester(t, 1, randomAddr, false) t.Run(test.name, func(t *testing.T) {
id := pt.IDs[0] randomAddr := RandomAddr()
addr := NewAddrFromNodeID(id) pt := newBzzHandshakeTester(t, 1, randomAddr, false)
peerLightNode := true id := pt.IDs[0]
addr := NewAddrFromNodeID(id)
err := pt.testHandshake( err := pt.testHandshake(
correctBzzHandshake(randomAddr, false), correctBzzHandshake(randomAddr, false),
&HandshakeMsg{Version: TestProtocolVersion, NetworkID: TestProtocolNetworkID, Addr: addr, LightNode: peerLightNode}, &HandshakeMsg{Version: TestProtocolVersion, NetworkID: TestProtocolNetworkID, Addr: addr, LightNode: test.lightNode},
) )
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
if pt.bzz.handshakes[id].LightNode != peerLightNode { if pt.bzz.handshakes[id].LightNode != test.lightNode {
t.Fatalf("peer LightNode flag is %v, should be %v", pt.bzz.handshakes[id].LightNode, peerLightNode) t.Fatalf("peer LightNode flag is %v, should be %v", pt.bzz.handshakes[id].LightNode, test.lightNode)
}
})
} }
} }