core, ethdb, trie: rename Sync to SyncKeyValue

core/headerchain.go

@@ -611,7 +611,7 @@ func (hc *HeaderChain) setHead(headBlock uint64, headTime uint64, updateFn Updat
 	}
 	// Explicitly flush the pending writes in the key-value store to disk, ensuring
 	// data durability of the previous deletions.
-	if err := hc.chainDb.Sync(); err != nil {
+	if err := hc.chainDb.SyncKeyValue(); err != nil {
 		log.Crit("Failed to sync the key-value store in setHead", "err", err)
 	}
 	// Truncate the excessive chain segments in the ancient store.

core/rawdb/table.go

@@ -188,10 +188,10 @@ func (t *table) Compact(start []byte, limit []byte) error {
 	return t.db.Compact(start, limit)
 }
 
-// Sync ensures that all pending writes are flushed to disk, guaranteeing
+// SyncKeyValue ensures that all pending writes are flushed to disk,
-// data durability up to the point.
+// guaranteeing data durability up to the point.
-func (t *table) Sync() error {
+func (t *table) SyncKeyValue() error {
-	return t.db.Sync()
+	return t.db.SyncKeyValue()
 }
 
 // NewBatch creates a write-only database that buffers changes to its host db

ethdb/database.go

@@ -59,9 +59,9 @@ type KeyValueStater interface {
 
 // KeyValueSyncer wraps the Sync method of a backing data store.
 type KeyValueSyncer interface {
-	// Sync ensures that all pending writes are flushed to disk, guaranteeing
+	// SyncKeyValue ensures that all pending writes are flushed to disk,
-	// data durability up to the point.
+	// guaranteeing data durability up to the point.
-	Sync() error
+	SyncKeyValue() error
 }
 
 // Compacter wraps the Compact method of a backing data store.

ethdb/leveldb/leveldb.go

@@ -324,9 +324,9 @@ func (db *Database) Path() string {
 	return db.fn
 }
 
-// Sync flushes all pending writes in the write-ahead-log to disk, ensuring
+// SyncKeyValue flushes all pending writes in the write-ahead-log to disk,
-// data durability up to that point.
+// ensuring data durability up to that point.
-func (db *Database) Sync() error {
+func (db *Database) SyncKeyValue() error {
 	// In theory, the WAL (Write-Ahead Log) can be explicitly synchronized using
 	// a write operation with SYNC=true. However, there is no dedicated key reserved
 	// for this purpose, and even a nil key (key=nil) is considered a valid

ethdb/memorydb/memorydb.go

@@ -199,9 +199,9 @@ func (db *Database) Compact(start []byte, limit []byte) error {
 	return nil
 }
 
-// Sync ensures that all pending writes are flushed to disk, guaranteeing
+// SyncKeyValue ensures that all pending writes are flushed to disk,
-// data durability up to the point.
+// guaranteeing data durability up to the point.
-func (db *Database) Sync() error {
+func (db *Database) SyncKeyValue() error {
 	return nil
 }
 

ethdb/pebble/pebble.go

@@ -431,9 +431,9 @@ func (d *Database) Path() string {
 	return d.fn
 }
 
-// Sync flushes all pending writes in the write-ahead-log to disk, ensuring
+// SyncKeyValue flushes all pending writes in the write-ahead-log to disk,
-// data durability up to that point.
+// ensuring data durability up to that point.
-func (d *Database) Sync() error {
+func (d *Database) SyncKeyValue() error {
 	// The entry (value=nil) is not written to the database; it is only
 	// added to the WAL. Writing this special log entry in sync mode
 	// automatically flushes all previous writes, ensuring database

ethdb/remotedb/remotedb.go

@@ -138,7 +138,7 @@ func (db *Database) Compact(start []byte, limit []byte) error {
 	return nil
 }
 
-func (db *Database) Sync() error {
+func (db *Database) SyncKeyValue() error {
 	return nil
 }
 

trie/trie_test.go

@@ -830,7 +830,7 @@ func (s *spongeDb) NewBatch() ethdb.Batch                    { return &spongeBat
 func (s *spongeDb) NewBatchWithSize(size int) ethdb.Batch    { return &spongeBatch{s} }
 func (s *spongeDb) Stat() (string, error)                    { panic("implement me") }
 func (s *spongeDb) Compact(start []byte, limit []byte) error { panic("implement me") }
-func (s *spongeDb) Sync() error                              { return nil }
+func (s *spongeDb) SyncKeyValue() error                      { return nil }
 func (s *spongeDb) Close() error                             { return nil }
 func (s *spongeDb) Put(key []byte, value []byte) error {
 	var (

triedb/pathdb/database.go

@@ -460,7 +460,7 @@ func (db *Database) Recover(root common.Hash) error {
 	// recent key-value writes are lost due to an application panic, while
 	// the associated state histories have already been removed, resulting
 	// in the inability to perform a state rollback.
-	if err := db.diskdb.Sync(); err != nil {
+	if err := db.diskdb.SyncKeyValue(); err != nil {
 		return err
 	}
 	_, err := truncateFromHead(db.diskdb, db.freezer, dl.stateID())