forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-12 09:51:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/state/snapshot: handle bloom filter errors in rebloom

Browse source 
The diffLayer.rebloom method silently discards errors from both
bloomfilter.New and parent.diffed.Copy. If either fails
(e.g. due to memory pressure or corrupted parent bloom),
dl.diffed remains nil, which causes a nil pointer dereference
in subsequent snapshot lookups via accountBloomHash.

Handle errors explicitly: fall back to a fresh bloom on copy
failure, and return early on allocation failure with a logged
error.
This commit is contained in:
Mayveskii 2026-03-26 20:24:41 +03:00
parent 8a3a309fa9
commit 56c00211a8
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
core/state/snapshot/difflayer.go
View file

@ -29,6 +29,7 @@ import (
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/core/types"
"github.com/ethereum/go-ethereum/log"
"github.com/ethereum/go-ethereum/rlp"
bloomfilter "github.com/holiman/bloomfilter/v2"
)
@ -173,10 +174,20 @@ func (dl *diffLayer) rebloom(origin *diskLayer) {
// Retrieve the parent bloom or create a fresh empty one
if parent, ok := dl.parent.(*diffLayer); ok {
parent.lock.RLock()
dl.diffed, _ = parent.diffed.Copy()
bloom, err := parent.diffed.Copy()
parent.lock.RUnlock()
if err != nil {
log.Error("Failed to copy parent bloom filter", "err", err)
bloom, _ = bloomfilter.New(uint64(bloomSize), uint64(bloomFuncs))
}
dl.diffed = bloom
} else {
dl.diffed, _ = bloomfilter.New(uint64(bloomSize), uint64(bloomFuncs))
bloom, err := bloomfilter.New(uint64(bloomSize), uint64(bloomFuncs))
if err != nil {
log.Error("Failed to create bloom filter", "err", err)
return
}
dl.diffed = bloom
}
for hash := range dl.accountData {
dl.diffed.AddHash(accountBloomHash(hash))