From 57b5c6d8d9e614869ce73abaf33bb55f14623625 Mon Sep 17 00:00:00 2001 From: Tanvir Date: Tue, 28 Apr 2026 23:55:56 +0800 Subject: [PATCH] eth/protocols/snap: downgrade log levels for storage retrieval messages Downgrade `log.Info` to `log.Debug` and `log.Error` to `log.Warn` for suspended storage retrieval logs in snap sync, as marked by the TODO comments --- eth/protocols/snap/sync.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/eth/protocols/snap/sync.go b/eth/protocols/snap/sync.go index 841bfb446e..9bbe572172 100644 --- a/eth/protocols/snap/sync.go +++ b/eth/protocols/snap/sync.go @@ -1998,15 +1998,13 @@ func (s *Syncer) processAccountResponse(res *accountResponse) { // The hash of last delivered account in the response last := res.hashes[len(res.hashes)-1] for hash := range res.task.SubTasks { - // TODO(rjl493456442) degrade the log level before merging. if hash.Cmp(last) > 0 { - log.Info("Keeping suspended storage retrieval", "account", hash) + log.Debug("Keeping suspended storage retrieval", "account", hash) continue } - // TODO(rjl493456442) degrade the log level before merging. // It should never happen in ethereum. if _, ok := resumed[hash]; !ok { - log.Error("Aborting suspended storage retrieval", "account", hash) + log.Warn("Aborting suspended storage retrieval", "account", hash) delete(res.task.SubTasks, hash) largeStorageDiscardGauge.Inc(1) }