forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-22 20:56:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

add an additional span inside runMethod to capture JSON response encoding overhead

Browse source
This commit is contained in:
jonny rhea 2026-01-02 11:27:01 -06:00
parent 6229224d66
commit 5961c2012e
1 changed files with 19 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
rpc/handler.go
View file

@ -504,8 +504,8 @@ func (h *handler) handleCallMsg(ctx *callProc, msg *jsonrpcMessage) *jsonrpcMess
// handleCall processes method calls. // handleCall processes method calls.
func (h *handler) handleCall(cp *callProc, msg *jsonrpcMessage) *jsonrpcMessage { func (h *handler) handleCall(cp *callProc, msg *jsonrpcMessage) *jsonrpcMessage {
// Start root span for the request. // Start root span for the request.
ctx, cspan := h.startSpan(cp.ctx, msg, "rpc.handleCall", cp.isBatch) ctx, rootSpan := h.startSpan(cp.ctx, msg, "rpc.handleCall", cp.isBatch)
defer cspan.End() defer rootSpan.End()
if msg.isSubscribe() { if msg.isSubscribe() {
return h.handleSubscribe(cp, msg) return h.handleSubscribe(cp, msg)
} }
@ -529,6 +529,7 @@ func (h *handler) handleCall(cp *callProc, msg *jsonrpcMessage) *jsonrpcMessage
if err != nil { if err != nil {
pspan.RecordError(err) pspan.RecordError(err)
pspan.SetStatus(codes.Error, err.Error()) pspan.SetStatus(codes.Error, err.Error())
rootSpan.SetStatus(codes.Error, err.Error())
return msg.errorResponse(&invalidParamsError{err.Error()}) return msg.errorResponse(&invalidParamsError{err.Error()})
} }
pspan.End() pspan.End()
@ -536,11 +537,10 @@ func (h *handler) handleCall(cp *callProc, msg *jsonrpcMessage) *jsonrpcMessage
// Start tracing span before running the method. // Start tracing span before running the method.
rctx, rspan := h.startSpan(ctx, msg, "rpc.runMethod", cp.isBatch) rctx, rspan := h.startSpan(ctx, msg, "rpc.runMethod", cp.isBatch)
answer := h.runMethod(rctx, msg, callb, args) answer := h.runMethod(rctx, msg, callb, args, cp.isBatch)
if answer.Error != nil { if answer.Error != nil {
err := errors.New(answer.Error.Message) err := errors.New(answer.Error.Message)
rspan.RecordError(err) rootSpan.SetStatus(codes.Error, err.Error())
rspan.SetStatus(codes.Error, err.Error())
} }
rspan.End() rspan.End()
@ -594,7 +594,7 @@ func (h *handler) handleSubscribe(cp *callProc, msg *jsonrpcMessage) *jsonrpcMes
n := &Notifier{h: h, namespace: namespace} n := &Notifier{h: h, namespace: namespace}
cp.notifiers = append(cp.notifiers, n) cp.notifiers = append(cp.notifiers, n)
ctx := context.WithValue(cp.ctx, notifierKey{}, n) ctx := context.WithValue(cp.ctx, notifierKey{}, n)
return h.runMethod(ctx, msg, callb, args) return h.runMethod(ctx, msg, callb, args, cp.isBatch)
} }
// startSpan starts a tracing span for an RPC call. // startSpan starts a tracing span for an RPC call.
@ -631,12 +631,23 @@ func (h *handler) tracer() trace.Tracer {
} }
// runMethod runs the Go callback for an RPC method. // runMethod runs the Go callback for an RPC method.
func (h *handler) runMethod(ctx context.Context, msg *jsonrpcMessage, callb *callback, args []reflect.Value) *jsonrpcMessage { func (h *handler) runMethod(ctx context.Context, msg *jsonrpcMessage, callb *callback, args []reflect.Value, isBatch bool) *jsonrpcMessage {
result, err := callb.call(ctx, msg.Method, args) result, err := callb.call(ctx, msg.Method, args)
parentSpan := trace.SpanFromContext(ctx)
if err != nil { if err != nil {
parentSpan.SetStatus(codes.Error, err.Error())
return msg.errorResponse(err) return msg.errorResponse(err)
} }
return msg.response(result) _, span := h.startSpan(ctx, msg, "rpc.response", isBatch)
response := msg.response(result)
if response.Error != nil {
err := errors.New(response.Error.Message)
span.RecordError(err)
span.SetStatus(codes.Error, err.Error())
parentSpan.SetStatus(codes.Error, err.Error())
}
span.End()
return response
} }
// unsubscribe is the callback function for all *_unsubscribe calls. // unsubscribe is the callback function for all *_unsubscribe calls.