forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-23 05:06:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

eth/protocols: fast exit if request range reversed

Browse source
This commit is contained in:
jsvisa 2025-10-29 23:48:57 +08:00
parent 5dd0fe2f53
commit 59b9de5c7d
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
eth/protocols/snap/handler.go
View file

@ -277,6 +277,10 @@ func ServiceGetAccountRangeQuery(chain *core.BlockChain, req *GetAccountRangePac
if req.Bytes > softResponseLimit { if req.Bytes > softResponseLimit {
req.Bytes = softResponseLimit req.Bytes = softResponseLimit
} }
// Validate the request range
if bytes.Compare(req.Origin[:], req.Limit[:]) > 0 {
return nil, nil
}
// Retrieve the requested state and bail out if non existent // Retrieve the requested state and bail out if non existent
tr, err := trie.New(trie.StateTrieID(req.Root), chain.TrieDB()) tr, err := trie.New(trie.StateTrieID(req.Root), chain.TrieDB())
if err != nil { if err != nil {
@ -342,6 +346,10 @@ func ServiceGetStorageRangesQuery(chain *core.BlockChain, req *GetStorageRangesP
if req.Bytes > softResponseLimit { if req.Bytes > softResponseLimit {
req.Bytes = softResponseLimit req.Bytes = softResponseLimit
} }
// Validate the request range
if bytes.Compare(req.Origin[:], req.Limit[:]) > 0 {
return nil, nil
}
// TODO(karalabe): Do we want to enforce > 0 accounts and 1 account if origin is set? // TODO(karalabe): Do we want to enforce > 0 accounts and 1 account if origin is set?
// TODO(karalabe): - Logging locally is not ideal as remote faults annoy the local user // TODO(karalabe): - Logging locally is not ideal as remote faults annoy the local user
// TODO(karalabe): - Dropping the remote peer is less flexible wrt client bugs (slow is better than non-functional) // TODO(karalabe): - Dropping the remote peer is less flexible wrt client bugs (slow is better than non-functional)