From 5acfa594f44e64bcc22cec334cbd9720b36ba5ba Mon Sep 17 00:00:00 2001 From: devopsbo3 <69951731+devopsbo3@users.noreply.github.com> Date: Fri, 10 Nov 2023 12:27:53 -0600 Subject: [PATCH] Revert "graphql: fix an issue of nil pointer panic (#28416)" This reverts commit 503c8d434705326e6fbecacc0e0d3ad3584a5eea. --- graphql/graphql.go | 3 --- graphql/graphql_test.go | 5 ----- 2 files changed, 8 deletions(-) diff --git a/graphql/graphql.go b/graphql/graphql.go index 93313d743a..50f0c6ca47 100644 --- a/graphql/graphql.go +++ b/graphql/graphql.go @@ -1325,9 +1325,6 @@ func (r *Resolver) Blocks(ctx context.Context, args struct { From *Long To *Long }) ([]*Block, error) { - if args.From == nil { - return nil, errors.New("from block number must be specified") - } from := rpc.BlockNumber(*args.From) var to rpc.BlockNumber diff --git a/graphql/graphql_test.go b/graphql/graphql_test.go index 540a56778c..4bbfb7251d 100644 --- a/graphql/graphql_test.go +++ b/graphql/graphql_test.go @@ -148,11 +148,6 @@ func TestGraphQLBlockSerialization(t *testing.T) { want: `{"data":{"block":{"number":"0xa","call":{"data":"0x","status":"0x1"}}}}`, code: 200, }, - { - body: `{"query": "{blocks {number}}"}`, - want: `{"errors":[{"message":"from block number must be specified","path":["blocks"]}],"data":null}`, - code: 400, - }, } { resp, err := http.Post(fmt.Sprintf("%s/graphql", stack.HTTPEndpoint()), "application/json", strings.NewReader(tt.body)) if err != nil {