core/tx_pool: reduce judgement levels (#16980)

This commit is contained in:
Daniel Liu 2024-05-08 13:50:49 +08:00
parent 859308c03f
commit 5b883dee30

View file

@ -954,13 +954,11 @@ func (pool *TxPool) addTxsLocked(txs []*types.Transaction, local bool) []error {
for i, tx := range txs { for i, tx := range txs {
var replace bool var replace bool
if replace, errs[i] = pool.add(tx, local); errs[i] == nil { if replace, errs[i] = pool.add(tx, local); errs[i] == nil && !replace {
if !replace {
from, _ := types.Sender(pool.signer, tx) // already validated from, _ := types.Sender(pool.signer, tx) // already validated
dirty[from] = struct{}{} dirty[from] = struct{}{}
} }
} }
}
// Only reprocess the internal state if something was actually added // Only reprocess the internal state if something was actually added
if len(dirty) > 0 { if len(dirty) > 0 {
addrs := make([]common.Address, 0, len(dirty)) addrs := make([]common.Address, 0, len(dirty))