From 5ba5254cfbf426756eef1ec8df71cb8a32393e6f Mon Sep 17 00:00:00 2001 From: Chris Ziogas Date: Wed, 3 Apr 2024 14:07:59 +0300 Subject: [PATCH] =?UTF-8?q?rename=20Hook=20=E2=80=9COnTerminate=E2=80=9D?= =?UTF-8?q?=20to=20=E2=80=9COnBlockchainTerminate=E2=80=9D?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- core/blockchain.go | 4 ++-- core/tracing/hooks.go | 18 +++++++++--------- eth/tracers/live/supply.go | 18 +++++++++--------- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/core/blockchain.go b/core/blockchain.go index bed78996be..564eef44e6 100644 --- a/core/blockchain.go +++ b/core/blockchain.go @@ -1172,8 +1172,8 @@ func (bc *BlockChain) Stop() { log.Error("Failed to close trie database", "err", err) } // Allow tracers to clean-up and release resources. - if bc.vmConfig.Tracer != nil && bc.vmConfig.Tracer.OnTerminate != nil { - bc.vmConfig.Tracer.OnTerminate() + if bc.vmConfig.Tracer != nil && bc.vmConfig.Tracer.OnBlockchainTerminate != nil { + bc.vmConfig.Tracer.OnBlockchainTerminate() } log.Info("Blockchain stopped") } diff --git a/core/tracing/hooks.go b/core/tracing/hooks.go index faf1ce4d96..6da079c6f0 100644 --- a/core/tracing/hooks.go +++ b/core/tracing/hooks.go @@ -107,6 +107,9 @@ type ( // BlockchainInitHook is called when the blockchain is initialized. BlockchainInitHook = func(chainConfig *params.ChainConfig) + // BlockchainTerminateHook is called when the tracer is terminated. + BlockchainTerminateHook = func() + // BlockStartHook is called before executing `block`. // `td` is the total difficulty prior to `block`. BlockStartHook = func(event BlockEvent) @@ -140,9 +143,6 @@ type ( // LogHook is called when a log is emitted. LogHook = func(log *types.Log) - - // TerminateHook is called when the tracer is terminated. - TerminateHook = func() ) type Hooks struct { @@ -155,18 +155,18 @@ type Hooks struct { OnFault FaultHook OnGasChange GasChangeHook // Chain events - OnBlockchainInit BlockchainInitHook - OnBlockStart BlockStartHook - OnBlockEnd BlockEndHook - OnSkippedBlock SkippedBlockHook - OnGenesisBlock GenesisBlockHook + OnBlockchainInit BlockchainInitHook + OnBlockchainTerminate BlockchainTerminateHook + OnBlockStart BlockStartHook + OnBlockEnd BlockEndHook + OnSkippedBlock SkippedBlockHook + OnGenesisBlock GenesisBlockHook // State events OnBalanceChange BalanceChangeHook OnNonceChange NonceChangeHook OnCodeChange CodeChangeHook OnStorageChange StorageChangeHook OnLog LogHook - OnTerminate TerminateHook } // BalanceChangeReason is used to indicate the reason for a balance change, useful diff --git a/eth/tracers/live/supply.go b/eth/tracers/live/supply.go index f352be940f..6123ca88d6 100644 --- a/eth/tracers/live/supply.go +++ b/eth/tracers/live/supply.go @@ -78,14 +78,14 @@ func newSupply(cfg json.RawMessage) (*tracing.Hooks, error) { logger: logger, } return &tracing.Hooks{ - OnBlockStart: t.OnBlockStart, - OnBlockEnd: t.OnBlockEnd, - OnGenesisBlock: t.OnGenesisBlock, - OnTxStart: t.OnTxStart, - OnBalanceChange: t.OnBalanceChange, - OnEnter: t.OnEnter, - OnExit: t.OnExit, - OnTerminate: t.OnTerminate, + OnBlockStart: t.OnBlockStart, + OnBlockEnd: t.OnBlockEnd, + OnGenesisBlock: t.OnGenesisBlock, + OnTxStart: t.OnTxStart, + OnBalanceChange: t.OnBalanceChange, + OnEnter: t.OnEnter, + OnExit: t.OnExit, + OnBlockchainTerminate: t.OnBlockchainTerminate, }, nil } @@ -230,7 +230,7 @@ func (s *supply) OnExit(depth int, output []byte, gasUsed uint64, err error, rev s.txCallstack[size-1].calls = append(s.txCallstack[size-1].calls, call) } -func (s *supply) OnTerminate() { +func (s *supply) OnBlockchainTerminate() { if err := s.logger.Close(); err != nil { log.Warn("failed to close supply tracer log file", "error", err) }