forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-12 09:51:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

eth/protocols/snap: handle StateReader error in ServiceTrieNodesQuery

Browse source 
When the snapshot is unavailable, ServiceTrieNodesQuery falls
back to triedb.StateReader but discards the error. If
StateReader fails (e.g. state pruned or DB corruption), the
nil reader is passed to trie operations, causing a nil pointer
dereference when serving trie node requests.

Return a proper error instead of silently proceeding with a
nil state reader.
This commit is contained in:
Mayveskii 2026-03-26 20:21:58 +03:00
parent 8a3a309fa9
commit 5cafd07009
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
eth/protocols/snap/handler.go
View file

@ -561,7 +561,11 @@ func ServiceGetTrieNodesQuery(chain *core.BlockChain, req *GetTrieNodesPacket, s
reader = chain.Snapshots().Snapshot(req.Root)
}
if reader == nil {
reader, _ = triedb.StateReader(req.Root)
var err error
reader, err = triedb.StateReader(req.Root)
if err != nil {
return nil, fmt.Errorf("failed to create state reader for root %x: %w", req.Root, err)
}
}
// Retrieve trie nodes until the packet size limit is reached