From 5d5404e75d6d2be767682903b3ea30755555c9af Mon Sep 17 00:00:00 2001 From: Alex Wu Date: Sun, 24 Dec 2017 16:18:51 +0800 Subject: [PATCH] crypto: fix TestToECDSAErrors for nocgo --- crypto/crypto.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/crypto/crypto.go b/crypto/crypto.go index e51726e624..7c353a8506 100644 --- a/crypto/crypto.go +++ b/crypto/crypto.go @@ -97,6 +97,17 @@ func toECDSA(d []byte, strict bool) (*ecdsa.PrivateKey, error) { return nil, fmt.Errorf("invalid length, need %d bits", priv.Params().BitSize) } priv.D = new(big.Int).SetBytes(d) + + // The priv.D must < N + if priv.D.Cmp(secp256k1_N) >= 0 { + return nil, fmt.Errorf("invalid private key, >=N") + } + // The priv.D must not be zero or negative. + zero := new(big.Int).SetInt64(0) + if priv.D.Cmp(zero) <= 0 { + return nil, fmt.Errorf("invalid private key, zero or negative") + } + priv.PublicKey.X, priv.PublicKey.Y = priv.PublicKey.Curve.ScalarBaseMult(d) if priv.PublicKey.X == nil { return nil, errors.New("invalid private key")