From 61b17c3bce3bb13d7e19b781e9fa1340ed405754 Mon Sep 17 00:00:00 2001
From: Zsolt Felfoldi <zsfelfoldi@gmail.com>
Date: Wed, 12 Mar 2025 15:30:18 +0100
Subject: [PATCH] core/filtermaps: do not use exported channels

---
 core/filtermaps/filtermaps.go   | 12 ++++----
 core/filtermaps/indexer.go      | 54 +++++++++++++++++++++++++++++----
 core/filtermaps/indexer_test.go |  3 +-
 3 files changed, 56 insertions(+), 13 deletions(-)

diff --git a/core/filtermaps/filtermaps.go b/core/filtermaps/filtermaps.go
index 090347bd2f..46cc80b04b 100644
--- a/core/filtermaps/filtermaps.go
+++ b/core/filtermaps/filtermaps.go
@@ -91,9 +91,9 @@ type FilterMaps struct {
 	finalBlock, lastFinal uint64
 	lastFinalEpoch        uint32
 	stop                  bool
-	TargetViewCh          chan *ChainView
-	FinalBlockCh          chan uint64
-	BlockProcessingCh     chan bool
+	targetViewCh          chan *ChainView
+	finalBlockCh          chan uint64
+	blockProcessingCh     chan bool
 	blockProcessing       bool
 	matcherSyncCh         chan *FilterMapsMatcherBackend
 	waitIdleCh            chan chan bool
@@ -184,9 +184,9 @@ func NewFilterMaps(db ethdb.KeyValueStore, initView *ChainView, params Params, h
 		db:                db,
 		closeCh:           make(chan struct{}),
 		waitIdleCh:        make(chan chan bool),
-		TargetViewCh:      make(chan *ChainView),
-		FinalBlockCh:      make(chan uint64),
-		BlockProcessingCh: make(chan bool),
+		targetViewCh:      make(chan *ChainView, 1),
+		finalBlockCh:      make(chan uint64, 1),
+		blockProcessingCh: make(chan bool, 1),
 		history:           history,
 		noHistory:         noHistory,
 		unindexLimit:      unindexLimit,
diff --git a/core/filtermaps/indexer.go b/core/filtermaps/indexer.go
index ac554c7b6c..702203639a 100644
--- a/core/filtermaps/indexer.go
+++ b/core/filtermaps/indexer.go
@@ -66,6 +66,43 @@ func (f *FilterMaps) indexerLoop() {
 	}
 }
 
+// SetTargetView sets a new target chain view for the indexer to render.
+// Note that SetTargetView never blocks.
+func (f *FilterMaps) SetTargetView(targetView *ChainView) {
+	for {
+		select {
+		case <-f.targetViewCh:
+		case f.targetViewCh <- targetView:
+			return
+		}
+	}
+}
+
+// SetFinalBlock sets the finalized block number used for exporting checkpoints.
+// Note that SetFinalBlock never blocks.
+func (f *FilterMaps) SetFinalBlock(finalBlock uint64) {
+	for {
+		select {
+		case <-f.finalBlockCh:
+		case f.finalBlockCh <- finalBlock:
+			return
+		}
+	}
+}
+
+// SetBlockProcessing sets the block processing flag that temporarily suspends
+// log index rendering.
+// Note that SetBlockProcessing never blocks.
+func (f *FilterMaps) SetBlockProcessing(blockProcessing bool) {
+	for {
+		select {
+		case <-f.blockProcessingCh:
+		case f.blockProcessingCh <- blockProcessing:
+			return
+		}
+	}
+}
+
 // WaitIdle blocks until the indexer is in an idle state while synced up to the
 // latest targetView.
 func (f *FilterMaps) WaitIdle() {
@@ -105,23 +142,28 @@ func (f *FilterMaps) processSingleEvent(blocking bool) bool {
 	}
 	if blocking {
 		select {
-		case targetView := <-f.TargetViewCh:
+		case targetView := <-f.targetViewCh:
 			f.setTargetView(targetView)
-		case f.finalBlock = <-f.FinalBlockCh:
+		case f.finalBlock = <-f.finalBlockCh:
 		case f.matcherSyncRequest = <-f.matcherSyncCh:
-		case f.blockProcessing = <-f.BlockProcessingCh:
+		case f.blockProcessing = <-f.blockProcessingCh:
 		case <-f.closeCh:
 			f.stop = true
 		case ch := <-f.waitIdleCh:
+			select {
+			case targetView := <-f.targetViewCh:
+				f.setTargetView(targetView)
+			default:
+			}
 			ch <- !f.blockProcessing && f.targetHeadIndexed()
 		}
 	} else {
 		select {
-		case targetView := <-f.TargetViewCh:
+		case targetView := <-f.targetViewCh:
 			f.setTargetView(targetView)
-		case f.finalBlock = <-f.FinalBlockCh:
+		case f.finalBlock = <-f.finalBlockCh:
 		case f.matcherSyncRequest = <-f.matcherSyncCh:
-		case f.blockProcessing = <-f.BlockProcessingCh:
+		case f.blockProcessing = <-f.blockProcessingCh:
 		case <-f.closeCh:
 			f.stop = true
 		default:
diff --git a/core/filtermaps/indexer_test.go b/core/filtermaps/indexer_test.go
index 1ec681aa0c..710fcb449f 100644
--- a/core/filtermaps/indexer_test.go
+++ b/core/filtermaps/indexer_test.go
@@ -414,7 +414,8 @@ func (tc *testChain) setTargetHead() {
 	head := tc.CurrentBlock()
 	if tc.ts.fm != nil {
 		if !tc.ts.fm.noHistory {
-			tc.ts.fm.TargetViewCh <- NewChainView(tc, head.Number.Uint64(), head.Hash())
+			//tc.ts.fm.targetViewCh <- NewChainView(tc, head.Number.Uint64(), head.Hash())
+			tc.ts.fm.SetTargetView(NewChainView(tc, head.Number.Uint64(), head.Hash()))
 		}
 	}
 }