From 62820feae53f5601a9e9c082b4c879d2b9362a05 Mon Sep 17 00:00:00 2001 From: teddy931130 Date: Wed, 15 Jan 2025 20:16:51 +0200 Subject: [PATCH] add build step to the workflow --- .github/workflows/build.yml | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 541d2dc53e..f1a9432a3f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -66,17 +66,24 @@ jobs: fi echo "new-tag=${NEW_TAG}" >> $GITHUB_OUTPUT - # - name: Build and push Docker Image - # run: | - # FULL_ECR_URL="${{ env.AWS_ACCOUNT_ID }}.dkr.ecr.${{ env.AWS_REGION }}.amazonaws.com/${{ env.ECR_REPO_NAME }}" - # NEW_TAG="${{ steps.get-latest-tag.outputs.new-tag }}" + - name: Build and push Docker Image + run: | + FULL_ECR_URL="${{ env.AWS_ACCOUNT_ID }}.dkr.ecr.${{ env.AWS_REGION }}.amazonaws.com/${{ env.ECR_REPO_NAME }}" + NEW_TAG="${{ steps.get-latest-tag.outputs.new-tag }}" - # docker build \ - # --build-arg VAR="VALUE" \ - # -t "${FULL_ECR_URL}:${NEW_TAG}" \ - # -f Dockerfile . + # define build args for the image + COMMIT=${{ github.sha }} + VERSION=$NEW_TAG + BUILDNUM=$(git rev-list --count HEAD) - # docker push "${FULL_ECR_URL}:${NEW_TAG}" + docker build \ + --build-arg COMMIT="${COMMIT}" \ + --build-arg VERSION="${VERSION}" \ + --build-arg BUILDNUM="${BUILDNUM}" \ + -t "${FULL_ECR_URL}:${NEW_TAG}" \ + -f Dockerfile . + + docker push "${FULL_ECR_URL}:${NEW_TAG}" - name: Notify PR of New Tag if: ${{ inputs.create_tag }} == 'true'