forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-27 23:26:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fixed KecakkPreimages to fit with legacy Firehose behavior that had a bug

Browse source
This commit is contained in:
Matthieu Vachon 2024-01-11 21:20:43 -05:00
parent 4862eeba1d
commit 6573cb21a5
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
eth/tracers/firehose.go
View file

@ -597,7 +597,20 @@ func (f *Firehose) CaptureKeccakPreimage(hash common.Hash, data []byte) {
activeCall.KeccakPreimages = make(map[string]string)
}
activeCall.KeccakPreimages[hex.EncodeToString(hash.Bytes())] = hex.EncodeToString(data)
// Known Firehose issue: It appears the old Firehose instrumentation have a bug
// where when the keccak256 preimage is empty, it is written as "." which is
// completely wrong.
//
// To keep the same behavior, we will write the preimage as a "." when the encoded
// data is an empty string.
//
// For new chain, this code should be remove so that we just keep `hex.EncodeToString(data)`.
encodedData := hex.EncodeToString(data)
if encodedData == "" {
encodedData = "."
}
activeCall.KeccakPreimages[hex.EncodeToString(hash.Bytes())] = encodedData
}
func (f *Firehose) OnGenesisBlock(b *types.Block, alloc core.GenesisAlloc) {