forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core: tiny comment nit fixups

Browse source
This commit is contained in:
Péter Szilágyi 2019-03-07 11:20:08 +02:00 committed by GitHub
parent d905ebb474
commit 666b117a45
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/tx_pool.go
View file

@ -818,7 +818,7 @@ func (pool *TxPool) AddRemotes(txs []*types.Transaction) []error {
// addTx enqueues a single transaction into the pool if it is valid. // addTx enqueues a single transaction into the pool if it is valid.
func (pool *TxPool) addTx(tx *types.Transaction, local bool) error { func (pool *TxPool) addTx(tx *types.Transaction, local bool) error {
// caching signature check result before holding lock significantly improve concurrency // Cache sender in transaction before obtaining lock (pool.signer is immutable)
types.Sender(pool.signer, tx) types.Sender(pool.signer, tx)
pool.mu.Lock() pool.mu.Lock()
@ -839,11 +839,10 @@ func (pool *TxPool) addTx(tx *types.Transaction, local bool) error {
// addTxs attempts to queue a batch of transactions if they are valid. // addTxs attempts to queue a batch of transactions if they are valid.
func (pool *TxPool) addTxs(txs []*types.Transaction, local bool) []error { func (pool *TxPool) addTxs(txs []*types.Transaction, local bool) []error {
// caching signature check result before holding lock significantly improve concurrency // Cache senders in transactions before obtaining lock (pool.signer is immutable)
for _, tx := range txs { for _, tx := range txs {
types.Sender(pool.signer, tx) types.Sender(pool.signer, tx)
} }
pool.mu.Lock() pool.mu.Lock()
defer pool.mu.Unlock() defer pool.mu.Unlock()