forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

p2p/discover: swap verification order in discv4 ping handler (#27532)

Browse source 
In all other UDPv4 methods, the deadline is checked first. It seems weird to me that ping is an exception. Deadline comparison is also less resource intensive.

Co-authored-by: Exca-DK <Exca-DK@users.noreply.github.com>
This commit is contained in:
Exca-DK 2023-06-22 10:06:14 +02:00 committed by devopsbo3
parent ff8659c6aa
commit 66d41a44f8
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
p2p/discover/v4_udp.go
View file

@ -643,13 +643,13 @@ type packetHandlerV4 struct {
func (t *UDPv4) verifyPing(h *packetHandlerV4, from *net.UDPAddr, fromID enode.ID, fromKey v4wire.Pubkey) error { func (t *UDPv4) verifyPing(h *packetHandlerV4, from *net.UDPAddr, fromID enode.ID, fromKey v4wire.Pubkey) error {
req := h.Packet.(*v4wire.Ping) req := h.Packet.(*v4wire.Ping)
if v4wire.Expired(req.Expiration) {
return errExpired
}
senderKey, err := v4wire.DecodePubkey(crypto.S256(), fromKey) senderKey, err := v4wire.DecodePubkey(crypto.S256(), fromKey)
if err != nil { if err != nil {
return err return err
} }
if v4wire.Expired(req.Expiration) {
return errExpired
}
h.senderKey = senderKey h.senderKey = senderKey
return nil return nil
} }