p2p/discv5: make idx bounds checking more sound

This commit is contained in:
HAOYUatHZ 2018-09-03 09:58:45 +08:00
parent 62e94895da
commit 670bc04058

View file

@ -1228,7 +1228,7 @@ func (net *Network) checkTopicRegister(data *topicRegister) (*pong, error) {
if rlpHash(data.Topics) != pongpkt.data.(*pong).TopicHash {
return nil, errors.New("topic hash mismatch")
}
if int(data.Idx) < 0 || int(data.Idx) >= len(data.Topics) {
if data.Idx >= uint(len(data.Topics)) {
return nil, errors.New("topic index out of range")
}
return pongpkt.data.(*pong), nil