forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-18 02:40:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: do not expose eth_close from the FilterAPI (#256)

Browse source 
## Why this should be merged

Currently, `eth_close` is being registered as an available RPC due to
`Close` being an exported function on the `FilterAPI`.

## How this works

Converts the method to a function that takes in the API.

## How this was tested

Updated unit test.
This commit is contained in:
Stephen Buttolph 2026-01-05 12:32:37 -05:00 committed by GitHub
parent a13de95b66
commit 6726b055f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
eth/filters/api.libevm.go
View file

@ -16,7 +16,9 @@
package filters package filters
// Close releases resources held by the API. // CloseAPI releases resources held by the API.
func (api *FilterAPI) Close() { //
// This is not implemented as a method to avoid exposing it via RPC.
func CloseAPI(api *FilterAPI) {
close(api.quit) close(api.quit)
} }

2
eth/filters/api.libevm_test.go
View file

@ -53,5 +53,5 @@ func TestClose(t *testing.T) {
defer backend.Close() defer backend.Close()
sys := NewFilterSystem(backend, Config{}) sys := NewFilterSystem(backend, Config{})
api := NewFilterAPI(sys, false) api := NewFilterAPI(sys, false)
api.Close() CloseAPI(api)
} }