forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-18 18:02:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

add comment about suboptimal-ness of the billy deletion iteration.

Browse source
This commit is contained in:
Jared Wasinger 2024-10-01 19:43:46 +07:00 committed by Felix Lange
parent 8827b3a5cb
commit 6738987786
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/txpool/blobpool/blobpool.go
View file

@ -1721,6 +1721,9 @@ func (p *BlobPool) DropTransactions() {
p.lock.Lock() p.lock.Lock()
defer p.lock.Unlock() defer p.lock.Unlock()
// manually iterating and deleting every entry is super sub-optimal
// However, DropTransactions is not currently used in production so
// performance is not critical at the moment.
for _, entry := range p.lookup { for _, entry := range p.lookup {
if err := p.store.Delete(entry); err != nil { if err := p.store.Delete(entry); err != nil {
log.Warn("failed to delete blob tx from backing store", "err", err) log.Warn("failed to delete blob tx from backing store", "err", err)