From 675effd03c270471c9b6618a29735b38039a710d Mon Sep 17 00:00:00 2001
From: 9547 <29431502+9547@users.noreply.github.com>
Date: Mon, 10 Jun 2024 22:35:00 +0800
Subject: [PATCH] internal: avoid large blob value copy

---
 internal/ethapi/transaction_args.go | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/internal/ethapi/transaction_args.go b/internal/ethapi/transaction_args.go
index f199f9d912..29ff17d071 100644
--- a/internal/ethapi/transaction_args.go
+++ b/internal/ethapi/transaction_args.go
@@ -325,13 +325,14 @@ func (args *TransactionArgs) setBlobTxSidecar(ctx context.Context) error {
 		// Generate commitment and proof.
 		commitments := make([]kzg4844.Commitment, n)
 		proofs := make([]kzg4844.Proof, n)
-		for i, b := range args.Blobs {
-			c, err := kzg4844.BlobToCommitment(&b)
+		for i := range args.Blobs {
+			b := &args.Blobs[i]
+			c, err := kzg4844.BlobToCommitment(b)
 			if err != nil {
 				return fmt.Errorf("blobs[%d]: error computing commitment: %v", i, err)
 			}
 			commitments[i] = c
-			p, err := kzg4844.ComputeBlobProof(&b, c)
+			p, err := kzg4844.ComputeBlobProof(b, c)
 			if err != nil {
 				return fmt.Errorf("blobs[%d]: error computing proof: %v", i, err)
 			}
@@ -340,8 +341,8 @@ func (args *TransactionArgs) setBlobTxSidecar(ctx context.Context) error {
 		args.Commitments = commitments
 		args.Proofs = proofs
 	} else {
-		for i, b := range args.Blobs {
-			if err := kzg4844.VerifyBlobProof(&b, args.Commitments[i], args.Proofs[i]); err != nil {
+		for i := range args.Blobs {
+			if err := kzg4844.VerifyBlobProof(&args.Blobs[i], args.Commitments[i], args.Proofs[i]); err != nil {
 				return fmt.Errorf("failed to verify blob proof: %v", err)
 			}
 		}