forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-23 05:06:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

triedb/pathdb: fix off-by-one for last state history ID and handle empty ranges

Browse source
This commit is contained in:
Forostovec 2025-11-05 10:33:34 +02:00 committed by GitHub
parent 395425902d
commit 67e689e161
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
triedb/pathdb/history_inspect.go
View file

@ -50,12 +50,12 @@ func sanitizeRange(start, end uint64, freezer ethdb.AncientReader) (uint64, uint
if err != nil { if err != nil {
return 0, 0, err return 0, 0, err
} }
last := head - 1 last := head
if end != 0 && end < last { if end != 0 && end < last {
last = end last = end
} }
// Make sure the range is valid // Make sure the range is valid
if first >= last { if first > last {
return 0, 0, fmt.Errorf("range is invalid, first: %d, last: %d", first, last) return 0, 0, fmt.Errorf("range is invalid, first: %d, last: %d", first, last)
} }
return first, last, nil return first, last, nil
@ -143,7 +143,11 @@ func historyRange(freezer ethdb.AncientReader) (uint64, uint64, error) {
if err != nil { if err != nil {
return 0, 0, err return 0, 0, err
} }
last := head - 1 // If there is no history available, return an explicit error.
if head == tail {
return 0, 0, fmt.Errorf("no history available")
}
last := head
fh, err := readStateHistory(freezer, first) fh, err := readStateHistory(freezer, first)
if err != nil { if err != nil {