From 69149ca133f64e3ce187452a7222c7125a6d67a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A9ter=20Szil=C3=A1gyi?= Date: Fri, 10 May 2019 16:07:32 +0300 Subject: [PATCH] core: address todo question wrt log count --- core/blockchain.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/core/blockchain.go b/core/blockchain.go index 86a8110766..91249ad9ba 100644 --- a/core/blockchain.go +++ b/core/blockchain.go @@ -1247,9 +1247,8 @@ func (bc *BlockChain) insertChain(chain types.Blocks, verifySeals bool) (int, [] } stats.processed++ - // TODO(karalabe): Can we assume canonicalness here? Can we assume no logs? - // In theory I can make a block *with* transactions but *no* state change if - // the only transactions are miner-self-sends or 0-price-self-sends. + // We can assume that logs are empty here, since the only way for consecutive + // Clique blocks to have the same state is if there are no transactions. events = append(events, ChainEvent{block, block.Hash(), nil}) lastCanon = block