forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 18:32:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ethstats: did some error handling in ethstats.go

Browse source
This commit is contained in:
Pratik Patil 2024-05-24 15:59:31 +05:30
parent b6474e9f90
commit 69b496bb5f
No known key found for this signature in database
GPG key ID: AFDCA496554874B3
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
ethstats/ethstats.go
View file

@ -632,6 +632,7 @@ func (s *Service) assembleBlockStats(block *types.Block) *blockStats {
td *big.Int td *big.Int
txs []txStats txs []txStats
uncles []*types.Header uncles []*types.Header
err error
) )
// check if backend is a full node // check if backend is a full node
@ -640,12 +641,13 @@ func (s *Service) assembleBlockStats(block *types.Block) *blockStats {
// Retrieve current chain head if no block is given. // Retrieve current chain head if no block is given.
if block == nil { if block == nil {
head := fullBackend.CurrentBlock() head := fullBackend.CurrentBlock()
block, _ = fullBackend.BlockByNumber(context.Background(), rpc.BlockNumber(head.Number.Uint64())) block, err = fullBackend.BlockByNumber(context.Background(), rpc.BlockNumber(head.Number.Uint64()))
} // Short circuit if no block is available. It might happen when
// Short circuit if no block is available. It might happen when // the blockchain is reorging.
// the blockchain is reorging. if err != nil {
if block == nil { log.Error("Failed to retrieve block by number", "err", err)
return nil return nil
}
} }
header = block.Header() header = block.Header()
td = fullBackend.GetTd(context.Background(), header.Hash()) td = fullBackend.GetTd(context.Background(), header.Hash())
@ -712,7 +714,7 @@ func (s *Service) reportHistory(conn *connWrapper, list []uint64) error {
// Retrieve the next block if it's known to us // Retrieve the next block if it's known to us
var block *types.Block var block *types.Block
if ok { if ok {
block, _ = fullBackend.BlockByNumber(context.Background(), rpc.BlockNumber(number)) // TODO ignore error here ? block, _ = fullBackend.BlockByNumber(context.Background(), rpc.BlockNumber(number))
} else { } else {
if header, _ := s.backend.HeaderByNumber(context.Background(), rpc.BlockNumber(number)); header != nil { if header, _ := s.backend.HeaderByNumber(context.Background(), rpc.BlockNumber(number)); header != nil {
block = types.NewBlockWithHeader(header) block = types.NewBlockWithHeader(header)