forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

internal/ethapi: remove warning for unspecified call sender

Browse source
This commit is contained in:
Felix Lange 2020-02-25 14:32:02 +01:00
parent 94b207b6c5
commit 6b550135b2
1 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
internal/ethapi/api.go
View file

@ -764,15 +764,13 @@ func DoCall(ctx context.Context, b Backend, args CallArgs, blockNrOrHash rpc.Blo
if state == nil || err != nil {
return nil, 0, false, err
}
// Set sender address or use a default if none specified
// Set sender address or use zero address if none specified.
var addr common.Address
if args.From != nil {
addr = *args.From
} else {
// At some point, make From mandatory. For now, we'll accept (but grumble a bit)
log.Warn("call made without 'from'-address specified -- using 0x0 as default")
//return errors.New("parameter 'from' is mandatory")
}
// Override the fields of specified contracts before execution.
for addr, account := range overrides {
// Override account nonce.
@ -904,13 +902,9 @@ func DoEstimateGas(ctx context.Context, b Backend, args CallArgs, blockNrOrHash
}
cap = hi
// Set sender address or use a default if none specified
// Use zero address if sender unspecified.
if args.From == nil {
// Use zero-address if none is specified
args.From = &common.Address{}
// At some point, make From mandatory. For now, we'll accept (but grumble a bit)
log.Warn("call made without 'from'-address specified -- using 0x0 as default")
//return errors.New("parameter 'from' is mandatory")
args.From = new(common.Address)
}
// Create a helper to check if a gas allowance results in an executable transaction
executable := func(gas uint64) bool {