forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 18:32:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

p2p/discover: update comment

Browse source
This commit is contained in:
Felix Lange 2024-05-28 19:02:23 +02:00
parent 3148497f2b
commit 6cab7ddfe0
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
p2p/discover/table.go
View file

@ -612,18 +612,19 @@ func (tab *Table) bumpInBucket(b *bucket, newRecord *enode.Node, isInbound bool)
return elem.ID() == newRecord.ID()
})
if i == -1 {
return nil, false // node not in bucket
return nil, false // not in bucket
}
// Disallow updates unless the sequence number is increased.
// Note there is a special case for discv4: if the node contacts us (isInbound),
// it is allowed to update its own entry.
n = b.entries[i]
// For inbound updates (from the node itself) we accept any change, even if it sets
// back the sequence number. For found nodes (!isInbound), seq has to advance. Note
// this check also ensures found discv4 nodes (which always have seq=0) can't be
// updated.
if newRecord.Seq() <= n.Seq() && !isInbound {
return n, false
}
// Check if there is an endpoint update and validate against IP limits.
// Check endpoint update against IP limits.
ipchanged := newRecord.IPAddr() != n.IPAddr()
portchanged := newRecord.UDP() != n.UDP()
if ipchanged {
@ -637,9 +638,8 @@ func (tab *Table) bumpInBucket(b *bucket, newRecord *enode.Node, isInbound bool)
// Apply update.
n.Node = newRecord
// Endpoint changes cause the node to be considered unverified.
if ipchanged || portchanged {
// Ensure node is revalidated quickly for endpoint changes.
tab.revalidation.nodeEndpointChanged(tab, n)
return n, true
}