mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-05-13 11:36:37 +00:00
core/types: reduce alloc in hot code path
This commit is contained in:
parent
b635e0632c
commit
6d415ae79a
1 changed files with 10 additions and 4 deletions
|
|
@ -317,11 +317,17 @@ func (tx *Transaction) To() *common.Address {
|
||||||
|
|
||||||
// Cost returns (gas * gasPrice) + (blobGas * blobGasPrice) + value.
|
// Cost returns (gas * gasPrice) + (blobGas * blobGasPrice) + value.
|
||||||
func (tx *Transaction) Cost() *big.Int {
|
func (tx *Transaction) Cost() *big.Int {
|
||||||
total := new(big.Int).Mul(tx.GasPrice(), new(big.Int).SetUint64(tx.Gas()))
|
// Avoid allocating copies via tx.GasPrice()/tx.Value(); use inner values directly.
|
||||||
if tx.Type() == BlobTxType {
|
total := new(big.Int).SetUint64(tx.inner.gas())
|
||||||
total.Add(total, new(big.Int).Mul(tx.BlobGasFeeCap(), new(big.Int).SetUint64(tx.BlobGas())))
|
total.Mul(total, tx.inner.gasPrice())
|
||||||
|
if blobtx, ok := tx.inner.(*BlobTx); ok {
|
||||||
|
tmp := new(big.Int).SetUint64(blobtx.blobGas())
|
||||||
|
// BlobFeeCap is uint256.Int; ToBig allocates, but blob txs are rarer and
|
||||||
|
// this still removes several other allocations compared to the old code.
|
||||||
|
tmp.Mul(tmp, blobtx.BlobFeeCap.ToBig())
|
||||||
|
total.Add(total, tmp)
|
||||||
}
|
}
|
||||||
total.Add(total, tx.Value())
|
total.Add(total, tx.inner.value())
|
||||||
return total
|
return total
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue