internal/ethapi: add tests for GetRawTransaction* null-on-not-found

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

internal/ethapi/api_test.go

@@ -672,7 +672,7 @@ func (b testBackend) TxIndexDone() bool {
 	return true
 }
 func (b testBackend) GetPoolTransactions() (types.Transactions, error)         { panic("implement me") }
-func (b testBackend) GetPoolTransaction(txHash common.Hash) *types.Transaction { panic("implement me") }
+func (b testBackend) GetPoolTransaction(txHash common.Hash) *types.Transaction { return nil }
 func (b testBackend) GetPoolNonce(ctx context.Context, addr common.Address) (uint64, error) {
 	return 0, nil
 }
@@ -4339,3 +4339,132 @@ func TestStateMethodsDefaultToLatest(t *testing.T) {
 		[]any{map[common.Address][]common.Hash{acc: {slot}}, "latest"},
 		[]any{map[common.Address][]common.Hash{acc: {slot}}})
 }
+
+func TestRPCGetRawTransactionByHash(t *testing.T) {
+	t.Parallel()
+
+	var (
+		backend, txHashes = setupReceiptBackend(t, 2)
+		api               = NewTransactionAPI(backend, new(AddrLocker))
+	)
+
+	var testSuite = []struct {
+		txHash common.Hash
+		file   string
+	}{
+		// 0. legacy transfer tx (block 0 default case)
+		{
+			txHash: txHashes[0],
+			file:   "found-legacy",
+		},
+		// 1. create contract tx (block 1)
+		{
+			txHash: txHashes[1],
+			file:   "found-create",
+		},
+		// 2. zero hash, not in chain
+		{
+			txHash: common.Hash{},
+			file:   "txhash-empty",
+		},
+		// 3. unknown hash, not in chain
+		{
+			txHash: common.HexToHash("deadbeef"),
+			file:   "txhash-notfound",
+		},
+	}
+
+	for i, tt := range testSuite {
+		result, err := api.GetRawTransactionByHash(context.Background(), tt.txHash)
+		if err != nil {
+			t.Errorf("test %d: want no error, have %v", i, err)
+			continue
+		}
+		testRPCResponseWithFile(t, i, result, "eth_getRawTransactionByHash", tt.file)
+	}
+}
+
+func TestRPCGetRawTransactionByBlockHashAndIndex(t *testing.T) {
+	t.Parallel()
+
+	var (
+		backend, _ = setupReceiptBackend(t, 2)
+		api        = NewTransactionAPI(backend, new(AddrLocker))
+	)
+
+	block1 := backend.chain.GetBlockByNumber(1)
+	if block1 == nil {
+		t.Fatal("block 1 not found")
+	}
+	block1Hash := block1.Hash()
+	unknownHash := common.HexToHash("deadbeef")
+
+	var testSuite = []struct {
+		blockHash common.Hash
+		index     hexutil.Uint
+		file      string
+	}{
+		// 0. block 1, index 0 → found (legacy tx)
+		{
+			blockHash: block1Hash,
+			index:     0,
+			file:      "found-legacy",
+		},
+		// 1. block 1, index 1 → out of range → null
+		{
+			blockHash: block1Hash,
+			index:     1,
+			file:      "index-outofrange",
+		},
+		// 2. unknown block hash, index 0 → null
+		{
+			blockHash: unknownHash,
+			index:     0,
+			file:      "blockhash-notfound",
+		},
+	}
+
+	for i, tt := range testSuite {
+		result := api.GetRawTransactionByBlockHashAndIndex(context.Background(), tt.blockHash, tt.index)
+		testRPCResponseWithFile(t, i, result, "eth_getRawTransactionByBlockHashAndIndex", tt.file)
+	}
+}
+
+func TestRPCGetRawTransactionByBlockNumberAndIndex(t *testing.T) {
+	t.Parallel()
+
+	var (
+		backend, _ = setupReceiptBackend(t, 2)
+		api        = NewTransactionAPI(backend, new(AddrLocker))
+	)
+
+	var testSuite = []struct {
+		blockNumber rpc.BlockNumber
+		index       hexutil.Uint
+		file        string
+	}{
+		// 0. block 1, index 0 → found (legacy tx)
+		{
+			blockNumber: 1,
+			index:       0,
+			file:        "found-legacy",
+		},
+		// 1. block 1, index 1 → out of range → null
+		{
+			blockNumber: 1,
+			index:       1,
+			file:        "index-outofrange",
+		},
+		// 2. block 999, doesn't exist → null
+		{
+			blockNumber: 999,
+			index:       0,
+			file:        "blocknumber-notfound",
+		},
+	}
+
+	for i, tt := range testSuite {
+		result := api.GetRawTransactionByBlockNumberAndIndex(context.Background(), tt.blockNumber, tt.index)
+		testRPCResponseWithFile(t, i, result, "eth_getRawTransactionByBlockNumberAndIndex", tt.file)
+	}
+}

internal/ethapi/testdata/eth_getRawTransactionByBlockHashAndIndex-blockhash-notfound.json

@@ -0,0 +1 @@
+null

internal/ethapi/testdata/eth_getRawTransactionByBlockHashAndIndex-found-legacy.json

@@ -0,0 +1 @@
+"0xf8658084342770c0825208940d3ab14bbad3d99f4203bd7a11acb94882050e7e8203e8801ba0cd190747077598c3b9c5f21ea06f8487d6ab1e23358fbe0e0e0c4e64651b68f3a0467ebcb2186b332969991e2e25244959dcdb3feb7652ff6b81ce96e646d86abd"

internal/ethapi/testdata/eth_getRawTransactionByBlockHashAndIndex-index-outofrange.json

@@ -0,0 +1 @@
+null

internal/ethapi/testdata/eth_getRawTransactionByBlockNumberAndIndex-blocknumber-notfound.json

@@ -0,0 +1 @@
+null

internal/ethapi/testdata/eth_getRawTransactionByBlockNumberAndIndex-found-legacy.json

@@ -0,0 +1 @@
+"0xf8658084342770c0825208940d3ab14bbad3d99f4203bd7a11acb94882050e7e8203e8801ba0cd190747077598c3b9c5f21ea06f8487d6ab1e23358fbe0e0e0c4e64651b68f3a0467ebcb2186b332969991e2e25244959dcdb3feb7652ff6b81ce96e646d86abd"

internal/ethapi/testdata/eth_getRawTransactionByBlockNumberAndIndex-index-outofrange.json

@@ -0,0 +1 @@
+null

internal/ethapi/testdata/eth_getRawTransactionByHash-found-create.json

@@ -0,0 +1 @@
+"0xf85301842db1629182cf6c8080846080604026a0fa210b09f8a13ea096b3a005a5feb0270121ab259555898bf03826e993ec14f4a007173d180059852006668647a793207d488723b89acdd6c484273f16beb9aaa3"

internal/ethapi/testdata/eth_getRawTransactionByHash-found-legacy.json

@@ -0,0 +1 @@
+"0xf8658084342770c0825208940d3ab14bbad3d99f4203bd7a11acb94882050e7e8203e8801ba0cd190747077598c3b9c5f21ea06f8487d6ab1e23358fbe0e0e0c4e64651b68f3a0467ebcb2186b332969991e2e25244959dcdb3feb7652ff6b81ce96e646d86abd"

internal/ethapi/testdata/eth_getRawTransactionByHash-txhash-empty.json

@@ -0,0 +1 @@
+null

internal/ethapi/testdata/eth_getRawTransactionByHash-txhash-notfound.json

@@ -0,0 +1 @@
+null