forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-17 10:20:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

eth/protocols/eth: discard message before size check (#35289)

Browse source 
- Move `msg.Discard` defer ahead of the max message size check in
`handleMessage`.
- Ensures oversized messages are released when the handler returns
early.
This commit is contained in:
cui 2026-07-14 22:06:57 +08:00 committed by GitHub
parent 8d84e5001a
commit 6e6fcef0ba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
eth/protocols/eth/handler.go
View file

@ -224,10 +224,10 @@ func handleMessage(backend Backend, peer *Peer) error {
if err != nil { if err != nil {
return err return err
} }
defer msg.Discard()
if msg.Size > maxMessageSize { if msg.Size > maxMessageSize {
return fmt.Errorf("%w: %v > %v", errMsgTooLarge, msg.Size, maxMessageSize) return fmt.Errorf("%w: %v > %v", errMsgTooLarge, msg.Size, maxMessageSize)
} }
defer msg.Discard()
var handlers map[uint64]msgHandler var handlers map[uint64]msgHandler
switch peer.version { switch peer.version {

2
eth/protocols/snap/handler.go
View file

@ -160,10 +160,10 @@ func HandleMessage(backend Backend, peer *Peer) error {
if err != nil { if err != nil {
return err return err
} }
defer msg.Discard()
if msg.Size > maxMessageSize { if msg.Size > maxMessageSize {
return fmt.Errorf("%w: %v > %v", errMsgTooLarge, msg.Size, maxMessageSize) return fmt.Errorf("%w: %v > %v", errMsgTooLarge, msg.Size, maxMessageSize)
} }
defer msg.Discard()
var handlers map[uint64]msgHandler var handlers map[uint64]msgHandler
switch peer.version { switch peer.version {