forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-19 02:12:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

chore: improve custom error formatting in revert messages

Browse source
This commit is contained in:
Confucian 2024-10-23 17:30:16 +08:00
parent 3ef918538e
commit 71f257457d
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
internal/ethapi/errors.go
View file

@ -51,7 +51,7 @@ func newRevertError(revert []byte) *revertError {
if errUnpack == nil {
err = fmt.Errorf("%w: %v", vm.ErrExecutionReverted, reason)
} else {
err = fmt.Errorf("%w: %v", vm.ErrExecutionReverted, hexutil.Encode(revert))
err = fmt.Errorf("%w: %v", vm.ErrExecutionReverted, formatRevertError(revert))
}
return &revertError{
error: err,
@ -59,6 +59,18 @@ func newRevertError(revert []byte) *revertError {
}
}
// formatRevertError formats the revert data into a custom error message
func formatRevertError(revert []byte) string {
if len(revert) >= 4 {
selector := revert[:4]
params := revert[4:]
return fmt.Sprintf("custom error %s: %s",
hexutil.Encode(selector),
hexutil.Encode(params))
}
return hexutil.Encode(revert)
}
// TxIndexingError is an API error that indicates the transaction indexing is not
// fully finished yet with JSON error code and a binary data blob.
type TxIndexingError struct{}