From 722004ba57279f0b72eb3c1c5ac0a8e0052ca19e Mon Sep 17 00:00:00 2001 From: Matthew Halpern Date: Tue, 8 Jan 2019 18:36:24 -0800 Subject: [PATCH] ethdb_test: remove parallel database modification test cases The TestLDB_ParallelPutGet and TestMemoryDB_ParallelPutGet test cases are not adding any additional coverage beyond what the other test cases provide. --- ethdb/database_test.go | 69 ------------------------------------------ 1 file changed, 69 deletions(-) diff --git a/ethdb/database_test.go b/ethdb/database_test.go index 382fedbf9e..0c35d7789e 100644 --- a/ethdb/database_test.go +++ b/ethdb/database_test.go @@ -20,11 +20,8 @@ package ethdb_test import ( "bytes" - "fmt" "io/ioutil" "os" - "strconv" - "sync" "testing" "github.com/ethereum/go-ethereum/ethdb" @@ -146,69 +143,3 @@ func testPutGet(db ethdb.Database, t *testing.T) { } } } - -func TestLDB_ParallelPutGet(t *testing.T) { - db, remove := newTestLDB() - defer remove() - testParallelPutGet(db, t) -} - -func TestMemoryDB_ParallelPutGet(t *testing.T) { - testParallelPutGet(ethdb.NewMemDatabase(), t) -} - -func testParallelPutGet(db ethdb.Database, t *testing.T) { - const n = 8 - var pending sync.WaitGroup - - pending.Add(n) - for i := 0; i < n; i++ { - go func(key string) { - defer pending.Done() - err := db.Put([]byte(key), []byte("v"+key)) - if err != nil { - panic("put failed: " + err.Error()) - } - }(strconv.Itoa(i)) - } - pending.Wait() - - pending.Add(n) - for i := 0; i < n; i++ { - go func(key string) { - defer pending.Done() - data, err := db.Get([]byte(key)) - if err != nil { - panic("get failed: " + err.Error()) - } - if !bytes.Equal(data, []byte("v"+key)) { - panic(fmt.Sprintf("get failed, got %q expected %q", []byte(data), []byte("v"+key))) - } - }(strconv.Itoa(i)) - } - pending.Wait() - - pending.Add(n) - for i := 0; i < n; i++ { - go func(key string) { - defer pending.Done() - err := db.Delete([]byte(key)) - if err != nil { - panic("delete failed: " + err.Error()) - } - }(strconv.Itoa(i)) - } - pending.Wait() - - pending.Add(n) - for i := 0; i < n; i++ { - go func(key string) { - defer pending.Done() - _, err := db.Get([]byte(key)) - if err == nil { - panic("get succeeded") - } - }(strconv.Itoa(i)) - } - pending.Wait() -}