more review feedback

This commit is contained in:
Guillaume Ballet 2019-11-22 15:12:10 +01:00
parent 2d02a80f2a
commit 73e9340365

View file

@ -140,9 +140,15 @@ func (tm *testMatcher) whitelist(pattern string) {
tm.whitelistpat = regexp.MustCompile(pattern)
}
func TestDummyMatcherToKeepBothStaticcheckandHolimanHappy(t *testing.T) {
tm := testMatcher{}
tm.whitelist("")
func TestWhitelist(t *testing.T) {
t.Parallel()
tm := new(testMatcher)
tm.whitelist("invalid*")
tm.walk(t, rlpTestDir, func(t *testing.T, name string, test *RLPTest) {
if name[:len("invalidRLPTest.json")] != "invalidRLPTest.json" {
t.Fatalf("invalid test found: %s != invalidRLPTest.json", name)
}
})
}
// config defines chain config for tests matching the pattern.