forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-24 05:36:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/types: adding overflow checks on SetFromBig

Browse source 
Better check in case this is used as library.
Not using MustFromBig as we don't have control
over how this is being used.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
This commit is contained in:
Csaba Kiraly 2025-08-21 09:39:18 +02:00
parent 456a941e40
commit 74b386b035
No known key found for this signature in database
GPG key ID: 0FE274EE8C95166E
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
core/types/transaction.go
View file

@ -37,7 +37,7 @@ var (
ErrInvalidTxType = errors.New("transaction type not valid in this context") ErrInvalidTxType = errors.New("transaction type not valid in this context")
ErrTxTypeNotSupported = errors.New("transaction type not supported") ErrTxTypeNotSupported = errors.New("transaction type not supported")
ErrGasFeeCapTooLow = errors.New("fee cap less than base fee") ErrGasFeeCapTooLow = errors.New("fee cap less than base fee")
ErrGasFeeCapOverflow = errors.New("fee cap overflow, too large for uint256") ErrUint256Overflow = errors.New("bigint overflow, too large for uint256")
errShortTypedTx = errors.New("typed transaction too short") errShortTypedTx = errors.New("typed transaction too short")
errInvalidYParity = errors.New("'yParity' field must be 0 or 1") errInvalidYParity = errors.New("'yParity' field must be 0 or 1")
errVYParityMismatch = errors.New("'v' and 'yParity' fields do not match") errVYParityMismatch = errors.New("'v' and 'yParity' fields do not match")
@ -360,7 +360,9 @@ func (tx *Transaction) EffectiveGasTip(baseFee *big.Int) (*big.Int, error) {
dst := new(uint256.Int) dst := new(uint256.Int)
base := new(uint256.Int) base := new(uint256.Int)
if baseFee != nil { if baseFee != nil {
base.SetFromBig(baseFee) if base.SetFromBig(baseFee) {
return nil, ErrUint256Overflow
}
} }
err := tx.calcEffectiveGasTip(dst, base) err := tx.calcEffectiveGasTip(dst, base)
return dst.ToBig(), err return dst.ToBig(), err
@ -370,13 +372,15 @@ func (tx *Transaction) EffectiveGasTip(baseFee *big.Int) (*big.Int, error) {
// saves the result to dst. // saves the result to dst.
func (tx *Transaction) calcEffectiveGasTip(dst *uint256.Int, baseFee *uint256.Int) error { func (tx *Transaction) calcEffectiveGasTip(dst *uint256.Int, baseFee *uint256.Int) error {
if baseFee == nil { if baseFee == nil {
dst.SetFromBig(tx.inner.gasTipCap()) if dst.SetFromBig(tx.inner.gasTipCap()) {
return ErrUint256Overflow
}
return nil return nil
} }
var err error var err error
if dst.SetFromBig(tx.inner.gasFeeCap()) { if dst.SetFromBig(tx.inner.gasFeeCap()) {
return ErrGasFeeCapOverflow return ErrUint256Overflow
} }
if dst.Cmp(baseFee) < 0 { if dst.Cmp(baseFee) < 0 {
err = ErrGasFeeCapTooLow err = ErrGasFeeCapTooLow
@ -384,7 +388,9 @@ func (tx *Transaction) calcEffectiveGasTip(dst *uint256.Int, baseFee *uint256.In
dst.Sub(dst, baseFee) dst.Sub(dst, baseFee)
gasTipCap := new(uint256.Int) gasTipCap := new(uint256.Int)
gasTipCap.SetFromBig(tx.inner.gasTipCap()) if gasTipCap.SetFromBig(tx.inner.gasTipCap()) {
return ErrUint256Overflow
}
if gasTipCap.Cmp(dst) < 0 { if gasTipCap.Cmp(dst) < 0 {
dst.Set(gasTipCap) dst.Set(gasTipCap)
} }