From 75bfcf27a95f784fafc590e543f82f20ca839103 Mon Sep 17 00:00:00 2001 From: Jared Wasinger Date: Sun, 5 Oct 2025 16:05:21 +0800 Subject: [PATCH] add TODO not to investigate weird behavior and unexpected test failure --- core/blockchain.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/core/blockchain.go b/core/blockchain.go index 405e0a0d69..ae71302e0f 100644 --- a/core/blockchain.go +++ b/core/blockchain.go @@ -2156,9 +2156,13 @@ func (bc *BlockChain) ProcessBlock(parentRoot common.Hash, block *types.Block, s } ptime = time.Since(pstart) - // TODO: remove. gross. shouldn't have to manually call Finalise - // to pull in post-tx-execution state changes to the BAL here. - balTracer.Finalise() + // TODO: if I remove this check before executing balTracer.Finalise, the following test fails: + // ExecutionSpecBlocktests/shanghai/eip3855_push0/push0/push0_storage_overwrite.json + if constructBALForTesting { + // TODO: remove. gross. shouldn't have to manually call Finalise + // to pull in post-tx-execution state changes to the BAL here. + balTracer.Finalise() + } // unset the BAL-creation tracer (dirty) bc.cfg.VmConfig.Tracer = nil