From 762482ef2ccff4ea77e9de5e64d7a2da3573fa25 Mon Sep 17 00:00:00 2001 From: Martin Holst Swende Date: Thu, 6 Dec 2018 15:03:42 +0100 Subject: [PATCH] flags: disallow --dev in combo with --externalsigner --- cmd/utils/flags.go | 3 ++- node/config.go | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go index 60f3692a37..448be782b1 100644 --- a/cmd/utils/flags.go +++ b/cmd/utils/flags.go @@ -1174,7 +1174,8 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *eth.Config) { // Avoid conflicting network flags checkExclusive(ctx, DeveloperFlag, TestnetFlag, RinkebyFlag) checkExclusive(ctx, LightServFlag, SyncModeFlag, "light") - + // Can't use both ephemeral unlocked and external signer + checkExclusive(ctx, DeveloperFlag, ExternalSignerFlag) var ks *keystore.KeyStore if keystores := stack.AccountManager().Backends(keystore.KeyStoreType); len(keystores) > 0 { ks = keystores[0].(*keystore.KeyStore) diff --git a/node/config.go b/node/config.go index f1b4992683..2cfaa2365b 100644 --- a/node/config.go +++ b/node/config.go @@ -436,8 +436,11 @@ func makeAccountManager(conf *Config) (*accounts.Manager, string, error) { // Assemble the account manager and supported backends backends := []accounts.Backend{} if len(conf.ExternalSigner) > 0 { + log.Info("Using external signer", "url", conf.ExternalSigner) if extapi, err := external.NewExternalBackend(conf.ExternalSigner); err == nil { backends = append(backends, extapi) + } else { + log.Info("Error configuring external signer", "error", err) } } if len(backends) == 0 {