From 7641bcfd19599e2da0bd5c6f9155222a9ada7762 Mon Sep 17 00:00:00 2001 From: wit liu <765765346@qq.com> Date: Fri, 14 Nov 2025 22:34:33 +0800 Subject: [PATCH] core: replace if-else chain with tagged switch on err (#1751) --- core/blockchain.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/core/blockchain.go b/core/blockchain.go index b807e63189..1e55bc51bb 100644 --- a/core/blockchain.go +++ b/core/blockchain.go @@ -2095,16 +2095,18 @@ func (bc *BlockChain) PrepareBlock(block *types.Block) (err error) { return err } result, err := bc.getResultBlock(block, false) - if err == nil { + switch err { + case nil: bc.resultProcess.Add(block.Hash(), result) return nil - } else if err == ErrKnownBlock { + case ErrKnownBlock: return nil - } else if err == ErrStopPreparingBlock { + case ErrStopPreparingBlock: log.Debug("Stop prepare a block because calculating", "number", block.NumberU64(), "hash", block.Hash(), "validator", block.Header().Validator) return nil + default: + return err } - return err } func (bc *BlockChain) getResultBlock(block *types.Block, verifiedM2 bool) (*ResultProcessBlock, error) {