From 78c5d8d32454aec16db8e9573b6f50e50bbecba4 Mon Sep 17 00:00:00 2001 From: Martin Holst Swende Date: Mon, 4 Nov 2019 14:46:54 +0100 Subject: [PATCH] eth/downloader/queue: minor fixes --- eth/downloader/queue.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/eth/downloader/queue.go b/eth/downloader/queue.go index 425f249ba1..15fd66a9a5 100644 --- a/eth/downloader/queue.go +++ b/eth/downloader/queue.go @@ -316,14 +316,14 @@ func (q *queue) Schedule(headers []*types.Header, from uint64) []*types.Header { log.Warn("Header broke chain ancestry", "number", header.Number, "hash", hash) break } - if !header.EmptyBody() { - // Make sure no duplicate requests are executed - if _, ok := q.blockTaskPool[hash]; ok { - log.Warn("Header already scheduled for block fetch", "number", header.Number, "hash", hash) - } else { - q.blockTaskPool[hash] = header - q.blockTaskQueue.Push(header, -int64(header.Number.Uint64())) - } + // Make sure no duplicate requests are executed + // We cannot skip this, even if the block is empty, since this is + // what triggers the fetchResult creation. + if _, ok := q.blockTaskPool[hash]; ok { + log.Warn("Header already scheduled for block fetch", "number", header.Number, "hash", hash) + } else { + q.blockTaskPool[hash] = header + q.blockTaskQueue.Push(header, -int64(header.Number.Uint64())) } // Queue for receipt retrieval if q.mode == FastSync && !header.EmptyReceipts() {