forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-12 15:03:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

eth: close last iterator on successful db upgrage

Browse source
This commit is contained in:
Péter Szilágyi 2017-07-14 15:03:12 +03:00
parent 655a1802fa
commit 7f33092187
No known key found for this signature in database
GPG key ID: E9AE538CEDF8293D
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
eth/db_upgrade.go
View file

@ -53,7 +53,9 @@ func upgradeDeduplicateData(db ethdb.Database) func() error {
// Create an iterator to read the entire database and covert old lookup entires // Create an iterator to read the entire database and covert old lookup entires
it := db.(*ethdb.LDBDatabase).NewIterator() it := db.(*ethdb.LDBDatabase).NewIterator()
defer func() { defer func() {
it.Release() if it != nil {
it.Release()
}
}() }()
var ( var (
@ -119,6 +121,9 @@ func upgradeDeduplicateData(db ethdb.Database) func() error {
} else { } else {
log.Error("Database deduplication failed", "deduped", converted, "err", failed) log.Error("Database deduplication failed", "deduped", converted, "err", failed)
} }
it.Release()
it = nil
errc := <-stop errc := <-stop
errc <- failed errc <- failed
}() }()