forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-05-24 08:49:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/txpool: guard nil head subscription

Browse source
This commit is contained in:
apetro2 2026-03-19 00:24:39 +08:00
parent 469846166a
commit 7f64995ee3
1 changed files with 11 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
core/txpool/txpool_test.go
View file

@ -17,7 +17,6 @@
package txpool
import (
"errors"
"testing"
"time"
@ -33,41 +32,30 @@ type nilHeadSubChain struct{}
func (nilHeadSubChain) Config() *params.ChainConfig { return params.TestChainConfig }
func (nilHeadSubChain) CurrentBlock() *types.Header { return &types.Header{} }
func (nilHeadSubChain) CurrentBlock() *types.Header { return &types.Header{Root: types.EmptyRootHash} }
func (nilHeadSubChain) SubscribeChainHeadEvent(chan<- core.ChainHeadEvent) event.Subscription {
return nil
}
func (nilHeadSubChain) StateAt(common.Hash) (*state.StateDB, error) {
return nil, errors.New("not implemented")
return state.New(types.EmptyRootHash, state.NewDatabaseForTesting())
}
func TestTxPoolLoopNilHeadSubscription(t *testing.T) {
func TestTxPoolCloseNilHeadSubscription(t *testing.T) {
t.Parallel()
pool := &TxPool{
chain: nilHeadSubChain{},
quit: make(chan chan error),
term: make(chan struct{}),
sync: make(chan chan error),
// TxPool.BlockChain exists to allow mocked chains in tests. A mock that
// opts out of head notifications may return a nil subscription.
pool, err := New(0, nilHeadSubChain{}, nil)
if err != nil {
t.Fatalf("failed to create txpool: %v", err)
}
go pool.loop(nil)
errc := make(chan error, 1)
select {
case pool.quit <- errc:
case <-time.After(time.Second):
t.Fatal("timed out waiting for txpool loop to accept quit signal")
}
select {
case err := <-errc:
if err != nil {
t.Fatalf("unexpected close error: %v", err)
}
case <-time.After(time.Second):
t.Fatal("timed out waiting for txpool loop to stop")
if err := pool.Close(); err != nil {
t.Fatalf("unexpected close error: %v", err)
}
select {
case <-pool.term:
case <-time.After(time.Second):