forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-05-15 04:26:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

core/txpool: use cmp.Compare instead of subtraction (#34918)

Browse source 
This fixes a theoretical overflow condition if an account has an impossibly high nonce.
This commit is contained in:
cui 2026-05-10 19:03:57 +08:00 committed by GitHub
parent bcb68d23b3
commit 7facf9c129
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/txpool/locals/tx_tracker.go
View file

@ -18,6 +18,7 @@
package locals package locals
import ( import (
"cmp"
"slices" "slices"
"sync" "sync"
"time" "time"
@ -151,7 +152,7 @@ func (tracker *TxTracker) recheck(journalCheck bool) []*types.Transaction {
for _, list := range rejournal { for _, list := range rejournal {
// cmp(a, b) should return a negative number when a < b, // cmp(a, b) should return a negative number when a < b,
slices.SortFunc(list, func(a, b *types.Transaction) int { slices.SortFunc(list, func(a, b *types.Transaction) int {
return int(a.Nonce() - b.Nonce()) return cmp.Compare(a.Nonce(), b.Nonce())
}) })
} }
// Rejournal the tracker while holding the lock. No new transactions will // Rejournal the tracker while holding the lock. No new transactions will