core/types: reuse signtx #29152, close XFN-63 (#1631)

This commit is contained in:
Daniel Liu 2025-11-03 17:24:31 +08:00 committed by GitHub
parent 76aa15b7d0
commit 7fad428a8f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -98,13 +98,7 @@ func SignTx(tx *Transaction, s Signer, prv *ecdsa.PrivateKey) (*Transaction, err
// SignNewTx creates a transaction and signs it.
func SignNewTx(prv *ecdsa.PrivateKey, s Signer, txdata TxData) (*Transaction, error) {
tx := NewTx(txdata)
h := s.Hash(tx)
sig, err := crypto.Sign(h[:], prv)
if err != nil {
return nil, err
}
return tx.WithSignature(s, sig)
return SignTx(NewTx(txdata), s, prv)
}
// MustSignNewTx creates a transaction and signs it.